Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate > Getting Started #76

Merged
merged 7 commits into from
Feb 8, 2019

Conversation

Darking360
Copy link
Collaborator

@Darking360 Darking360 commented Feb 5, 2019

Translation of Getting Started page

Related: Original issue: Spanish Translation Progress

To Do:

  • Finish first translation draft

  • Check translation

  • Check grammar and orthography

  • Submit final

@Darking360 Darking360 changed the title ⚠️ WIP: Translate > Getting Started WIP: Translate > Getting Started Feb 5, 2019
@Darking360 Darking360 changed the title WIP: Translate > Getting Started Translate > Getting Started Feb 5, 2019
@Darking360
Copy link
Collaborator Author

Greetings! I just finished the translation for the getting started page 🚀

If any of you could take a look to it, and check if it's ok to be merged would be awesome 💪

CC: @dmoralesm @carburo @alejandronanez

Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Darking360, thanks for another great PR 🎉

Let a couple of minor changes that I think we should address before merging,

Let us know when it's ready!

Thanks again!

>
>Whenever you get confused by something in JavaScript, [MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript) and [javascript.info](http://javascript.info/) are great websites to check. There are also [community support forums](/community/support.html) where you can ask for help.
>Cuando te sientas confundido sobre algo de Javascript, [MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript) y [javascript.info](http://javascript.info/) son sitios increíbles para revisar. También hay un [foro de asistencia por la comunidad](/community/support.html) donde puedes pedir ayuda.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's link to the Spanish MDN docs!

Suggested change
>Cuando te sientas confundido sobre algo de Javascript, [MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript) y [javascript.info](http://javascript.info/) son sitios increíbles para revisar. También hay un [foro de asistencia por la comunidad](/community/support.html) donde puedes pedir ayuda.
>Cuando te sientas confundido sobre algo de Javascript, [MDN](https://developer.mozilla.org/es/docs/Web/JavaScript) y [javascript.info](http://javascript.info/) son sitios increíbles para revisar. También hay un [foro de asistencia por la comunidad](/community/support.html) donde puedes pedir ayuda.

content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
@Darking360
Copy link
Collaborator Author

Good morning 🌞 @alejandronanez !

I just committed the requested changes, whenever you can take a look and check if everything is ok would be nice 🙏

Let me know if anything changes 💪

CC: @carburo @dmoralesm

Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go @Darking360, awesome work! Thanks, thanks, thanks 🙏!

@alejandronanez alejandronanez merged commit 95ee4a5 into reactjs:master Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants